qa-tests: upload an rpc integration test report to our test database to show rpc test details using hive ui#19594
qa-tests: upload an rpc integration test report to our test database to show rpc test details using hive ui#19594mriccobene wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to enrich RPC integration test reporting by (a) increasing the verbosity of the RPC test runner output and (b) uploading an RPC integration test report file to the QA test database so Hive UI can display RPC test details.
Changes:
- Add
--verbose 1to therpc-testsintegration test runner invocation. - Pass a
--result_file($TEST_RESULT_DIR/test_report.json) toupload_test_results.pyin the RPC integration tests workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/scripts/run_rpc_tests.sh | Increases verbosity of run_tests.py output during RPC integration tests. |
| .github/workflows/qa-rpc-integration-tests.yml | Attempts to upload a JSON report file alongside the overall test outcome to the QA DB. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
|
|
||
| python3 $ERIGON_QA_PATH/test_system/qa-tests/uploads/upload_test_results.py --repo erigon --commit $(git rev-parse HEAD) --branch ${{ github.ref_name }} --test_name rpc-integration-tests --chain $CHAIN --runner ${{ runner.name }} --db_version $db_version --outcome $TEST_RESULT #--result_file ${{ github.workspace }}/result-$CHAIN.json | ||
| python3 $ERIGON_QA_PATH/test_system/qa-tests/uploads/upload_test_results.py --repo erigon --commit $(git rev-parse HEAD) --branch ${{ github.ref_name }} --test_name rpc-integration-tests --chain $CHAIN --runner ${{ runner.name }} --db_version $db_version --outcome $TEST_RESULT --result_file $TEST_RESULT_DIR/test_report.json |
There was a problem hiding this comment.
--result_file $TEST_RESULT_DIR/test_report.json is passed to upload_test_results.py, but this workflow doesn’t appear to create $TEST_RESULT_DIR/test_report.json anywhere (the test runner only produces output.log plus per-test artifacts). If the file is missing, the upload step will likely fail or upload empty data. Consider generating the report JSON into that path before this step (or fall back to omitting --result_file / gating the argument on -f existence).
No description provided.