Skip to content

execution/tests: add bal-devnet-3 fixtures and move bals hash check after post block validation and before commitment validation#19595

Merged
taratorio merged 3 commits intomainfrom
enable_devnet_3_tests
Mar 4, 2026
Merged

execution/tests: add bal-devnet-3 fixtures and move bals hash check after post block validation and before commitment validation#19595
taratorio merged 3 commits intomainfrom
enable_devnet_3_tests

Conversation

@taratorio
Copy link
Member

@taratorio taratorio commented Mar 4, 2026

DO NOT MERGE BEFORE #19528

  • adds the new bal-devnet-3 test fixtures and applies the skips for failing eips
  • moves the bals hash check after post block validation and before commitment verification so that we can clearly see the real errors (e.g. gas mismatches/receipt mismatches/etc) instead of always seeing block access list mismatch

@taratorio taratorio requested a review from shohamc1 March 4, 2026 01:29
@taratorio taratorio force-pushed the enable_devnet_3_tests branch from a277e35 to 1d0b0f9 Compare March 4, 2026 01:42
@taratorio taratorio changed the title execution/tests: add bal-devnet-3 fixtures and move bals hash check after post block validation and before commitment validation [DO-NOT-MERGE] execution/tests: add bal-devnet-3 fixtures and move bals hash check after post block validation and before commitment validation Mar 4, 2026
Copy link
Contributor

@mh0lt mh0lt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need a refactor when next merging main. The BALs code is now localized with versionedio.

@yperbasis yperbasis added the Glamsterdam https://eips.ethereum.org/EIPS/eip-7773 label Mar 4, 2026
@taratorio taratorio changed the title [DO-NOT-MERGE] execution/tests: add bal-devnet-3 fixtures and move bals hash check after post block validation and before commitment validation execution/tests: add bal-devnet-3 fixtures and move bals hash check after post block validation and before commitment validation Mar 4, 2026
@taratorio taratorio enabled auto-merge (squash) March 4, 2026 10:43
@taratorio taratorio merged commit f52f52a into main Mar 4, 2026
24 checks passed
@taratorio taratorio deleted the enable_devnet_3_tests branch March 4, 2026 11:05
sudeepdino008 pushed a commit that referenced this pull request Mar 4, 2026
…fter post block validation and before commitment validation (#19595)

DO NOT MERGE BEFORE #19528

- adds the new bal-devnet-3 test fixtures and applies the skips for
failing eips
- moves the bals hash check after post block validation and before
commitment verification so that we can clearly see the real errors (e.g.
gas mismatches/receipt mismatches/etc) instead of always seeing `block
access list mismatch`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Glamsterdam https://eips.ethereum.org/EIPS/eip-7773

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants