Conversation
a277e35 to
1d0b0f9
Compare
mh0lt
approved these changes
Mar 4, 2026
Contributor
mh0lt
left a comment
There was a problem hiding this comment.
This may need a refactor when next merging main. The BALs code is now localized with versionedio.
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
…fter post block validation and before commitment validation (#19595) DO NOT MERGE BEFORE #19528 - adds the new bal-devnet-3 test fixtures and applies the skips for failing eips - moves the bals hash check after post block validation and before commitment verification so that we can clearly see the real errors (e.g. gas mismatches/receipt mismatches/etc) instead of always seeing `block access list mismatch`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE BEFORE #19528
block access list mismatch