[SharovBot] Fix data race on bheapCache in db/rawdb#19606
Merged
AskAlexSharov merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
Add sync.RWMutex to protect concurrent access to the package-level bheapCache variable, which was being read in TruncateCanonicalHash and written in ResetBadBlockCache without synchronization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AskAlexSharov
approved these changes
Mar 4, 2026
Collaborator
AskAlexSharov
left a comment
AskAlexSharov
left a comment
There was a problem hiding this comment.
feels like need methods around bheapCache for this which will lock/unlock
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
**[SharovBot]** ## Summary - Fix DATA RACE between `TestBlockStorage` and `TestBadBlocks` in `db/rawdb` - Add `sync.RWMutex` to protect concurrent access to the package-level `bheapCache` variable - The variable was being read in `TruncateCanonicalHash` and written in `ResetBadBlockCache` without synchronization ## Test plan - [x] `go test -race ./db/rawdb/... -run "TestBlockStorage|TestBadBlocks" -count=3` passes with no DATA RACE - [x] `go build ./...` passes - [x] No test files modified 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SharovBot]
Summary
TestBlockStorageandTestBadBlocksindb/rawdbsync.RWMutexto protect concurrent access to the package-levelbheapCachevariableTruncateCanonicalHashand written inResetBadBlockCachewithout synchronizationTest plan
go test -race ./db/rawdb/... -run "TestBlockStorage|TestBadBlocks" -count=3passes with no DATA RACEgo build ./...passes🤖 Generated with Claude Code