check-commitment-hist-at-blk-range: support empty blocks, sampling logic extraction#19642
Open
AskAlexSharov wants to merge 17 commits intomainfrom
Open
check-commitment-hist-at-blk-range: support empty blocks, sampling logic extraction#19642AskAlexSharov wants to merge 17 commits intomainfrom
check-commitment-hist-at-blk-range: support empty blocks, sampling logic extraction#19642AskAlexSharov wants to merge 17 commits intomainfrom
Conversation
| return err | ||
| } | ||
| for gapBlock := latestBlockNum + 1; gapBlock < blockNum; gapBlock++ { | ||
| gapHeader, err := br.HeaderByNumber(ctx, tx, gapBlock) |
Member
There was a problem hiding this comment.
do we need this loop and check for empty blocks?
we can just compare with header stateroot hash and be done. That's enough check.
Member
There was a problem hiding this comment.
wait, i still see the "verify gap blocks" logic
I don't think we need checks for empty blocks? is it adding anything? we can remove it and keep things simple.
Collaborator
Author
There was a problem hiding this comment.
- we don't know "are they really empty?" - need proof by headers root compare
- even if "empty blocks" are real - we still need to check: that our StateHistory doesn't have any history events in this blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
or
Also:
--samplesupport