execution/abi: return errors for invalid ParseTopics output#20800
Open
JayeTurn wants to merge 1 commit intoerigontech:mainfrom
Open
execution/abi: return errors for invalid ParseTopics output#20800JayeTurn wants to merge 1 commit intoerigontech:mainfrom
JayeTurn wants to merge 1 commit intoerigontech:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens execution/abi topic parsing by preventing reflection panics and returning actionable ABI errors when ParseTopics can’t write decoded indexed fields into the provided destination, plus adding regression tests for invalid outputs.
Changes:
- Add destination validation and assignability checks to
ParseTopics, returning errors instead of panicking on bad outputs. - Update the internal
parseTopicWithSetterto propagate setter errors. - Add regression tests covering missing fields, type mismatches, and non-pointer outputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
execution/abi/topics.go |
Adds error-returning setter plumbing and validates/refuses invalid ParseTopics destinations/field mappings. |
execution/abi/topics_test.go |
Adds TestParseTopicsInvalidOutput to lock in error behavior for invalid outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
149
to
153
| return parseTopicWithSetter(fields, topics, | ||
| func(arg Argument, reconstr any) { | ||
| func(arg Argument, reconstr any) error { | ||
| out[arg.Name] = reconstr | ||
| return nil | ||
| }) |
Comment on lines
+122
to
+126
| func(arg Argument, reconstr any) error { | ||
| value := reflect.ValueOf(out) | ||
| if value.Kind() != reflect.Pointer || value.IsNil() { | ||
| return fmt.Errorf("abi: cannot unmarshal indexed event fields into %T", out) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseTopicsbefore setting reflected fields.