rpc: fix prestateTracer diff mode missing deleted accounts#20807
Draft
rpc: fix prestateTracer diff mode missing deleted accounts#20807
Conversation
…nts on main Port of release/3.4 fix (#20775): adds GetCodeHash to tracing.IntraBlockState so processDiffState can distinguish deleted accounts (NilCodeHash → zero hash) from codeless-but-existing ones (EmptyCodeHash). GetCode returns empty bytes for both cases and cannot make that distinction. Also replaces repeated t.pre[addr] map lookups with the range variable `state` and adds a compile-time interface assertion in the unit test. Fixes flaky rpc-compat test_42 (debug_traceBlockByNumber with prestateTracer diffMode:true). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lupin012
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of release/3.4 fix (#20775): adds GetCodeHash to tracing.IntraBlockState so processDiffState can distinguish deleted accounts (NilCodeHash → zero hash) from codeless-but-existing ones (EmptyCodeHash). GetCode returns empty bytes for both cases and cannot make that distinction.
Also replaces repeated t.pre[addr] map lookups with the range variable
stateand adds a compile-time interface assertion in the unit test.Fixes flaky rpc-compat test_42 (debug_traceBlockByNumber with prestateTracer diffMode:true).
The rpc-tests will be modified after merge PR #20755