Skip to content

CI: centralise RPC_VERSION in file and fix rpc-tests cache stale files #20824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lupin012 merged 12 commits into from
Apr 28, 2026
Merged

CI: centralise RPC_VERSION in file and fix rpc-tests cache stale files #20824

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f95fa63
ci: derive rpc-tests cache key from script hash instead of hardcoded …
lupin012 Apr 26, 2026
4317482
ci: clear stale rpc-tests dir on cache miss to avoid reusing workspac…
lupin012 Apr 26, 2026
d926540
ci: centralise RPC_VERSION in workflow env and remove hardcoded versi…
lupin012 Apr 26, 2026
ab9094f
ci: clean untracked files from rpc-tests cache to prevent stale test …
lupin012 Apr 26, 2026
6369031
ci: preserve .venv and build dirs when cleaning stale rpc-tests fixtu…
lupin012 Apr 27, 2026
bbe8e17
ci: move RPC_VERSION to rpc_version.env so scripts and workflows read…
lupin012 Apr 27, 2026
8b4d334
ci: restore original combined check for missing CHAIN/RPC_VERSION args
lupin012 Apr 27, 2026
8a85b36
ci: align clients to rpc_version.env and add RPC_VERSION guard in all…
lupin012 Apr 27, 2026
27a80e8
Merge branch 'main' into lupin012/clear_github_cache_for_rpc_tests
lupin012 Apr 27, 2026
f82c624
ci: temporarily disable debug_traceBlockByNumber test_33 and test_34
lupin012 Apr 27, 2026
dd40405
Merge branch 'main' into lupin012/clear_github_cache_for_rpc_tests
AskAlexSharov Apr 28, 2026
b860846
Merge branch 'main' into lupin012/clear_github_cache_for_rpc_tests
lupin012 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/qa-rpc-integration-tests-clients.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
ERIGON_QA_PATH: /home/qarunner/erigon-qa
RPC_PAST_TEST_DIR: /opt/rpc-past-tests
CHAIN: mainnet
RPC_VERSION: v2.4.0

steps:
- name: Check out repository
Expand All @@ -53,7 +54,7 @@ jobs:
uses: actions/cache@v5
with:
path: ${{ runner.workspace }}/rpc-tests
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-v2.4.0
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-${{ env.RPC_VERSION }}
Comment thread
lupin012 marked this conversation as resolved.

- name: Run RPC Integration Tests
id: test_step
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/qa-rpc-integration-tests-gnosis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
ERIGON_ASSERT: true
RPC_PAST_TEST_DIR: /opt/rpc-past-tests
CHAIN: gnosis
RPC_VERSION: v2.8.1

steps:
- name: Check out repository
Expand Down Expand Up @@ -73,7 +74,7 @@ jobs:
uses: actions/cache@v5
with:
path: ${{ runner.workspace }}/rpc-tests
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-v2.8.1
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-${{ env.RPC_VERSION }}
Comment thread
lupin012 marked this conversation as resolved.

- name: Run RPC Integration Tests
id: test_step
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/qa-rpc-integration-tests-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
ERIGON_ASSERT: true
RPC_PAST_TEST_DIR: /opt/rpc-past-tests
CHAIN: mainnet
RPC_VERSION: v2.8.1

steps:
- name: Check out repository
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/qa-rpc-integration-tests-remote.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
ERIGON_ASSERT: true
RPC_PAST_TEST_DIR: /opt/rpc-past-tests/remote
CHAIN: mainnet
RPC_VERSION: v2.8.1

steps:
- name: Check out repository
Expand Down Expand Up @@ -140,7 +141,7 @@ jobs:
uses: actions/cache@v5
with:
path: ${{ runner.workspace }}/rpc-tests
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-v1.121.0
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-${{ env.RPC_VERSION }}
Comment thread
lupin012 marked this conversation as resolved.

- name: Run RPC Integration Tests
id: test_step
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/qa-rpc-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
ERIGON_ASSERT: true
RPC_PAST_TEST_DIR: /opt/rpc-past-tests
CHAIN: mainnet
RPC_VERSION: v2.8.1
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow introduces RPC_VERSION: v2.8.1 as a hardcoded value, which still requires manual bumps to invalidate caches. Given the PR intent to auto-invalidate via script hash, consider removing the need for this hardcoded value by basing the cache key on hashFiles(...) (and only keeping RPC_VERSION if it is independently needed to select the rpc-tests ref).

Copilot uses AI. Check for mistakes.

steps:
- name: Check out repository
Expand Down Expand Up @@ -73,7 +74,7 @@ jobs:
uses: actions/cache@v5
with:
path: ${{ runner.workspace }}/rpc-tests
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-v2.8.1
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-${{ env.RPC_VERSION }}
Comment thread
lupin012 marked this conversation as resolved.

- name: Run RPC Integration Tests
id: test_step
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/qa-sync-from-scratch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
TOTAL_TIME_SECONDS: ${{ matrix.total_time_seconds || 43200 }} # 12 hours
CHAIN: ${{ matrix.chain }}
ERIGON_ASSERT: true
RPC_VERSION: v2.8.1

steps:
- name: Check out repository
Expand Down Expand Up @@ -143,7 +144,7 @@ jobs:
uses: actions/cache@v5
with:
path: ${{ runner.workspace }}/rpc-tests
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-v2.4.0
key: rpc-tests-${{ runner.os }}-${{ runner.arch }}-${{ env.RPC_VERSION }}
Comment thread
lupin012 marked this conversation as resolved.

- name: Run RPC Integration Tests
id: rpc_test_step
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/scripts/run_rpc_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -e # Enable exit on error

# Sanity check for mandatory parameters
if [ -z "$1" ] || [ -z "$2" ]; then
if [ -z "$1" ]; then
echo "Usage: $0 <CHAIN> <RPC_VERSION> [DISABLED_TESTS] [WORKSPACE] [RESULT_DIR] [TESTS_TYPE] [REFERENCE_HOST] [COMPARE_ERROR_MESSAGE] [DUMP_RESPONSE]"
echo
echo " CHAIN: The chain identifier (possible values: mainnet, gnosis, polygon)"
Expand All @@ -17,6 +17,10 @@ if [ -z "$1" ] || [ -z "$2" ]; then
echo
exit 1
fi
if [ -z "$2" ]; then
echo "Error: RPC_VERSION is not set — export RPC_VERSION=<tag> before running (e.g. vX.Y.Z)"
exit 1
fi

CHAIN="$1"
RPC_VERSION="$2"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scripts/run_rpc_tests_ethereum.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ DISABLED_TEST_LIST=(
DISABLED_TESTS=$(IFS=,; echo "${DISABLED_TEST_LIST[*]}")

# Call the main test runner script with the required and optional parameters
"$(dirname "$0")/run_rpc_tests.sh" mainnet v2.8.1 "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR"
"$(dirname "$0")/run_rpc_tests.sh" mainnet "$RPC_VERSION" "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR"
Comment thread
lupin012 marked this conversation as resolved.
2 changes: 1 addition & 1 deletion .github/workflows/scripts/run_rpc_tests_ethereum_latest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ DISABLED_TEST_LIST=(
DISABLED_TESTS=$(IFS=,; echo "${DISABLED_TEST_LIST[*]}")

# Call the main test runner script with the required and optional parameters
"$(dirname "$0")/run_rpc_tests.sh" mainnet v2.8.1 "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR" "latest" "$REFERENCE_HOST" "do-not-compare-error-message" "$DUMP_RESPONSE"
"$(dirname "$0")/run_rpc_tests.sh" mainnet "$RPC_VERSION" "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR" "latest" "$REFERENCE_HOST" "do-not-compare-error-message" "$DUMP_RESPONSE"
Comment thread
lupin012 marked this conversation as resolved.
2 changes: 1 addition & 1 deletion .github/workflows/scripts/run_rpc_tests_geth.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ DISABLED_TESTS=$(IFS=,; echo "${DISABLED_TEST_LIST[*]}")

Comment thread
lupin012 marked this conversation as resolved.
# Call the main test runner script with the required and optional parameters
# Use do-not-compare-error-message since Geth error messages differ from Erigon
"$(dirname "$0")/run_rpc_tests.sh" mainnet v2.4.0 "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR" "" "" "do-not-compare-error-message"
"$(dirname "$0")/run_rpc_tests.sh" mainnet "$RPC_VERSION" "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR" "" "" "do-not-compare-error-message"
2 changes: 1 addition & 1 deletion .github/workflows/scripts/run_rpc_tests_gnosis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ DISABLED_TEST_LIST=(
DISABLED_TESTS=$(IFS=,; echo "${DISABLED_TEST_LIST[*]}")

# Call the main test runner script with the required and optional parameters
"$(dirname "$0")/run_rpc_tests.sh" gnosis v2.8.1 "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR"
"$(dirname "$0")/run_rpc_tests.sh" gnosis "$RPC_VERSION" "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR"
Comment thread
lupin012 marked this conversation as resolved.

2 changes: 1 addition & 1 deletion .github/workflows/scripts/run_rpc_tests_nethermind.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ DISABLED_TESTS=$(IFS=,; echo "${DISABLED_TEST_LIST[*]}")

# Call the main test runner script with the required and optional parameters
# Use do-not-compare-error-message since Nethermind error messages differ from Erigon
"$(dirname "$0")/run_rpc_tests.sh" mainnet v2.4.0 "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR" "" "" "do-not-compare-error-message"
"$(dirname "$0")/run_rpc_tests.sh" mainnet "$RPC_VERSION" "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR" "" "" "do-not-compare-error-message"
Comment thread
lupin012 marked this conversation as resolved.
2 changes: 1 addition & 1 deletion .github/workflows/scripts/run_rpc_tests_remote_ethereum.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ DISABLED_TEST_LIST=(
DISABLED_TESTS=$(IFS=,; echo "${DISABLED_TEST_LIST[*]}")

# Call the main test runner script with the required and optional parameters
"$(dirname "$0")/run_rpc_tests.sh" mainnet v2.8.1 "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR"
"$(dirname "$0")/run_rpc_tests.sh" mainnet "$RPC_VERSION" "$DISABLED_TESTS" "$WORKSPACE" "$RESULT_DIR"
Comment thread
lupin012 marked this conversation as resolved.
Loading