[bal-devnet-3] cmd/utils, node/cli: add --exec.serial flag to clamp workers to 1#20863
Merged
mh0lt merged 1 commit intobal-devnet-3from Apr 28, 2026
Merged
[bal-devnet-3] cmd/utils, node/cli: add --exec.serial flag to clamp workers to 1#20863mh0lt merged 1 commit intobal-devnet-3from
mh0lt merged 1 commit intobal-devnet-3from
Conversation
mh0lt
requested review from
AskAlexSharov,
Giulio2002 and
yperbasis
as code owners
Follow-up to #20797. Adds a single-purpose boolean that forces serial execution by clamping the parallel executor's worker count to 1 — wins over both --exec.workers and EXEC3_WORKERS. Cleaner than `--exec.workers=1` because it states intent ("force serial") at the call site rather than relying on a magic value, and it can't be accidentally undone by a stale EXEC3_WORKERS env var that gets re-read by tooling. Use case: like-for-like baseline comparisons against the parallel executor (devnet A/B runs, profiling cold paths) where the operator explicitly wants serial irrespective of any other knob. Wiring: applied AFTER --exec.workers in SetEthConfig, so: --exec.serial=true → workers=1 --exec.workers=12 --exec.serial=true → workers=1 (serial wins) --exec.workers=12 → workers=12 --exec.serial=false (default) → no override Test: TestExecPerfFlags_OverrideDbg covers serial-true, serial-vs-workers precedence, and serial-false-leaves-untouched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mh0lt
force-pushed
the
cp/20853-to-bal-devnet-3
branch
from
78f1d97 to
898ad84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #20853 to bal-devnet-3. Depends on #20862 (#20797 cherry-pick).