rpc: Fix regression on eth_createAccessList and add mgt ctx.err in loop#21086
Draft
rpc: Fix regression on eth_createAccessList and add mgt ctx.err in loop#21086
Conversation
The convergence loop had no ctx.Err() check, so when the HTTP context expired (300s timeout) the goroutine kept running indefinitely. Geth has this check; add the equivalent to Erigon. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…excl 'to' was added to the exclusion map so it wouldn't appear as a redundant address entry in the access list (EIP-2929 pre-warms it). However, fix #21036 made NewAccessListTracer fully skip excluded addresses AND their storage slots. This broke convergence: each iteration the EVM adds 'to's storage slots to the tracer (SLOAD/SSTORE have no exclusion check in OnOpcode), but the next prevTracer strips them, so the two tracers never match. Remove 'to' from excl so its storage slots propagate correctly through the convergence loop. The address entry for 'to' appearing in the result is redundant but harmless — its slots must be warmed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lupin012
changed the title
AskAlexSharov
approved these changes
May 10, 2026
lupin012
force-pushed
the
lupin012/fix-create-access-list-ctx-check
branch
from
5a22d1e to
a02a122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 2 fixes:
Update: test_15 is OK with the new changes, but test_17 fails.
I found a similar Geth PR (#34887) merged recently.
I'll check Geth's historical responses to fix the expected output for test_17.