polygon: delete the Polygon tree, tables, protos and chain-config hooks - #23497
Conversation
…ocs and QA workflow
…e from the Polygon cleanup
…emoval-db-storage
…removal-chain-config
…n-removal-delete-tree # Conflicts: # cmd/utils/app/init_cmd.go
# Conflicts: # cmd/downloader/main.go # cmd/integration/commands/stages.go # node/eth/backend.go
# Conflicts: # cmd/integration/commands/stages.go
…ng' into HEAD # Conflicts: # cmd/integration/commands/stages.go # cmd/rpcdaemon/cli/config.go # cmd/utils/app/init_cmd.go # cmd/utils/app/snapshots_cmd.go
…der docs and the golangci exclusions
…eftover Polygon stubs
…removal-chain-config
…n-removal-delete-tree
…tables and drop their stale AuRa cfg entries
…e' into awskii/polygon-removal-db-storage
…fig' into awskii/polygon-removal-chain-config
…removal-chain-config
…ee' into awskii/polygon-removal-delete-tree
…n-removal-delete-tree
…ng them behind the witness rename
|
4-agent review over the incremental range ( Major — the renamed witness tables had no schema migration.
Fixed by Worth stating explicitly, since it is the obvious question on a PR that removes Polygon: the tables are renamed rather than deleted because they belong to the WIT side-protocol, not to Bor. Minor, fixed — Minor, fixed — Minor, open — the Also swept the tip for anything the series missed and dropped five stale references in a161860: the |
…ee' into awskii/polygon-removal-delete-tree
Nothing outside
polygon/referenced it after #23495, so this deletes the tree and the hooks that existed to serve it. Last in the Polygon removal series, branched off #23495 — review the last commit only.erigonno longer builds, reads or serves anything Polygon. Existing Polygon chaindata is rejected with a pointer to0xPolygon/erigonrather than loaded with its consensus settings silently dropped.Changes
polygon/— 17 packages, ~20k lines of Go and 25.7 MB of Heimdall test fixturesexecution/chain: removeConfig.Bor,Config.BorJSON, theBorConfiginterface,BorRules, and the Bor arms ofString(),getEngine()andSecondsPerSlot()db/kv: remove the 13 remainingBor*tables, the deadBorTablesCfg, and theHeimdallDB/PolygonBridgeDBlabels with their table configskv.BorWitnesses/kv.BorWitnessSizestokv.Witnesses/kv.WitnessSizesand gate the witness buffer on--wit-protocolinstead of the chainsnaptype.MinBorEnumbecomesMaxCaplinEnum, same value, so the on-disk enum numbering is unchangedremote/bor.proto, its generated files, and theBorTxnLookup/BorEventsmethods onETHBACKEND; regenerate; bumpEthBackendAPIVersionto 4.0.0MimetypeBor,BorValidateHeaderTime, the Bor block-end receipt recovery in the serial and custom-trace executors, and the last Bor branches inSysCallContractandgenesiswritego mod tidydropsgo-merkle,ttlcacheandarc/v2, which only Bor usedbor.*/polygon.pos.*flag reference; regeneratellms*.txtThe witness protocol
The
wit/0protocol read and wrotekv.BorWitnesses, so deleting those tables would have disabled it outright rather than removing something Polygon-specific. The protocol itself has no Polygon logic — only its table names and its buffer'schainConfig.Bor != nilgate did. The tables are renamed and the buffer now follows--wit-protocol, which is what the flag's name already implied.That gate change is the one behaviour change here, and it is forced: there is no Bor config left to gate on. Witness ingestion is now reachable on any chain when the flag is set. No supported chain ever wrote those tables, so the rename orphans no data. If witness ingestion should stay off by default on Ethereum, that is a follow-up on the flag, not on this deletion.
Left for a follow-up
rules.EngineReader.GetPostApplyMessageFuncnow returns nil from every implementation — Bor's fee-transfer logging was the only real one. Removing the hook touches four engines and two call sites in the parallel and serial executors, which does not belong in a deletion this size..github/workflows/scripts/test_report/generate-test-report.tsanddashboards/keep their Polygon handling: both render historical QA results, and stripping the mappings would break display of past runs.