datastore: inverted index range query#2632
Merged
battlmonstr merged 6 commits intomasterfrom Jan 14, 2025
Merged
Conversation
battlmonstr
force-pushed
the
pr/ii_queries
branch
11 times, most recently
from
69a9dbe to
8fb9ead
Compare
battlmonstr
force-pushed
the
pr/ii_queries
branch
3 times, most recently
from
d38b23f to
5c9dfe2
Compare
battlmonstr
changed the title
battlmonstr
force-pushed
the
pr/ii_queries
branch
12 times, most recently
from
e276d2c to
d0ef77b
Compare
battlmonstr
force-pushed
the
pr/ii_queries
branch
3 times, most recently
from
08fde34 to
4603d8e
Compare
battlmonstr
force-pushed
the
pr/ii_queries
branch
from
4603d8e to
e0485c3
Compare
canepat
approved these changes
Jan 14, 2025
battlmonstr
pushed a commit
that referenced
this pull request
Jan 17, 2025
Fix the errors in Windows build after #2632: - `kvdb/inverted_index_range_by_key_query_test.cpp`: explicit conversion from `std::filesystem::path` to `std::string` - `snapshots/elias_fano/list_iterator.hpp`: `ListIterator::operator*` now returns `value_type` to fix MSVC conversion error. We could rename `ListIterator` as `ValueListIterator` to highlight it indeed iterates over primitive type values (i.e. integers) plus other errors come to light after these: - `local_transaction.cpp`, `concat_view_test.cpp`: add dual overloaded `operator==` and `operator!=` for `std::default_sentinel_t` in `ConcatView` *Extras* fix some MSVC warnings
Sixtysixter
pushed a commit
that referenced
this pull request
Jan 21, 2025
Fix the errors in Windows build after #2632: - `kvdb/inverted_index_range_by_key_query_test.cpp`: explicit conversion from `std::filesystem::path` to `std::string` - `snapshots/elias_fano/list_iterator.hpp`: `ListIterator::operator*` now returns `value_type` to fix MSVC conversion error. We could rename `ListIterator` as `ValueListIterator` to highlight it indeed iterates over primitive type values (i.e. integers) plus other errors come to light after these: - `local_transaction.cpp`, `concat_view_test.cpp`: add dual overloaded `operator==` and `operator!=` for `std::default_sentinel_t` in `ConcatView` *Extras* fix some MSVC warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.