rpc: investigate refund option #2644
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2644 +/- ##
==========================================
- Coverage 50.64% 50.62% -0.02%
==========================================
Files 784 784
Lines 52452 52456 +4
Branches 8107 8109 +2
==========================================
- Hits 26562 26555 -7
- Misses 23581 23582 +1
- Partials 2309 2319 +10 ☔ View full report in Codecov by Sentry. |
chfast
force-pushed
the
ci/rpc_refund_option
branch
2 times, most recently
from
229996a to
b41c7d4
Compare
chfast
force-pushed
the
ci/rpc_refund_option
branch
from
b41c7d4 to
9ebdff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to investigate
NoRefundJSON option fordebug_trace*RPC methods. This option seems to disable gas refunds application after any transaction execution. This option is not present in the geth's RPC.This PR if the option is ever used in Silkworm tests. It seems not.