Skip to content

Add comments to applyRequestState continue clauses #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mh0lt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add comments to applyRequestState continue clauses #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions requesting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,12 +312,19 @@ func (p *Peer) applyRequestState(next desiredRequestState) {
panic("changed")
}

// don't add requests on receipt of a reject - because this causes request back
// to potentially permanently unresponsive peers - which just adds network noise. If
// the peer can handle more requests it will send an "unchoked" message - which
// will cause it to get added back to the request queue
if p.needRequestUpdate == "Peer.remoteRejectedRequest" {
continue
}

existing := t.requestingPeer(req)
if existing != nil && existing != p {
// don't steal on cancel - because this is triggered by t.cancelRequest below
// which means that the cancelled can immediately try to steal back a request
// it has lost which can lead to circular cancel/add processing
if p.needRequestUpdate == "Peer.cancel" {
continue
}
Expand Down