Address static analyzer warning in OCPartialMockObject (Issue #543)

[LowAmmo]

• Issue OCPartialMockObject static analyzer warning #543 about potential nil passed to class_addMethod()

OCPartialMockObject#setupForwarderForSelector

• Modified to just return if there is no existing implementation for the method

[LowAmmo]

@erikdoe - Any chance this could be merged so it's in any future OCMock releases?

-Thanks!

[erikdoe]

To be honest, it's a long time since I wrote that code, but returning early from the method if originalIMP is null – as suggested in the PR – might be a bit too simple. I mean, there is the code to create types when originalMethod is null, and the forwarder is installed in such cases.

A less risky/invasive change would be to skip only the call to class_addMethod when originalIMP is null. This could have a performance impact, though, because this would skip setting any entry for aliasSelector` which means the if statement at the top of the method wouldn't be true on later invocations.

I think my assumption was that it was okay to set NULL as an implementation and that would trigger a forwarding mechanism. Looking at the header file for class_addMethod, that assumption is clearly wrong, at least today, and the third parameter must not be null. But that also means that it probably never is null. So, skipping the class_addMethod only to make the analyzer happy seems a sensible idea. (Famous last words...)

[LowAmmo]

@erikdoe - You've got a much better understanding of the innerworkings of all of this than I do, so I will gladly defer to your gut instincts! 😄

I do suspect you're right, that there is enough other "safety" checks that just skipping the call to "class_addMethod" is likely okay in this erroneous instance of a consumer trying to mock a method that doesn't exist (or can't be found) via ObjC. Especially since it doesn't seem to be causing problems, today - other than the warning message I'm trying to clean up. 😄

[LowAmmo]

@erikdoe - Just hoping to get this approved & pulled in & released to cocoapods sometime soon?

-Thanks!

[LowAmmo]

@erikdoe - Just pinging you to hopefully get this PR on your radar to pull in sometime soon... 😄

[LowAmmo]

@erikdoe - just pinging to see about getting this pulled in?

[LowAmmo]

@erikdoe - checking in again about getting this pulled in?

(as an additional option - if you are finding yourself without enough time to keep maintaining this library...I'd be willing to be made a github & cocoapod admin to help out)