Render edit mode line by line#537
Open
erikjuhani wants to merge 3 commits into
Open
Conversation
Editing used to flip the whole block to raw on entry, and rendering it from the AST during edits drifted from the source, so nested lists and structural edits were unreliable. Render the active block with a line decorator that maps 1:1 to source lines: the cursor's line is raw and editable, the rest are decorated in place. This keeps indentation, blank lines and code blocks faithful to the source and makes editing predictable. Read mode and non-active blocks keep the AST renderer; unifying the two is tracked in #533. Changelog: changed
erikjuhani
force-pushed
the
line-by-line-raw-rendering
branch
from
b383092 to
f5bdfae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing used to flip the whole block to raw on entry, and rendering it from the AST during edits drifted from the source, so nested lists and structural edits were unreliable.
Render the active block with a line decorator that maps 1:1 to source lines: the cursor's line is raw and editable, the rest are decorated in place. This keeps indentation, blank lines and code blocks faithful to the source and makes editing predictable.
Read mode and non-active blocks keep the AST renderer; unifying the two is tracked in #533.