feat(cmpc): closure-predicate evaluator + bilateral type profile (PR 3 of 6)#30
Open
eriknewton wants to merge 1 commit into
Open
feat(cmpc): closure-predicate evaluator + bilateral type profile (PR 3 of 6)#30eriknewton wants to merge 1 commit into
eriknewton wants to merge 1 commit into
Conversation
Base automatically changed from
feat/cmpc-stage3-chain-session-state-machine-2026-05-18
to
main
May 19, 2026 02:37
…3 of 6) PR 3 of the 6-PR CMPC Stage 3 bilateral campaign. Builds on PR #29 state machine. - concordia/cmpc/predicate.py: ClosurePredicate, PredicateResult, evaluate_predicate - Boolean composition: and/or/not - Comparison: ==, !=, >=, <=, >, < - Set membership: in - Time comparison: before/after on ISO 8601 strings - Aggregation: sum, min, max, count over all chain commitments - Bilateral type profile registered: urn:concordia:predicate-type:bilateral_chain_closure:v1 - Profile evaluator: expected_participants subset check + aggregate quantity within tolerance + timing pre-deadline + optional mandate-proof presence - Fixture matrix covers Boolean + comparison + aggregation + bilateral-profile happy + 4 failure modes - pytest 1168 + mypy clean within baseline v0.7.0a0 track preserved; no PyPI publish. Design doc: Review/Concordia/CMPC_Stage_3_Bilateral_Beer_Game_Design_Doc_2026-05-16.md
eriknewton
force-pushed
the
feat/cmpc-stage3-closure-predicate-evaluator-2026-05-18
branch
from
1107ac2 to
35f06ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 3 of 6 CMPC Stage 3 bilateral. Closes design doc Primitive 3.\n\nDependency note: PR #29 is still open, so this PR is based on feat/cmpc-stage3-chain-session-state-machine-2026-05-18 rather than main. Retarget to main after PR #29 lands if needed.\n\nChecks run:\n- .venv/bin/pytest tests/cmpc/test_closure_predicate.py -v: 19 passed\n- .venv/bin/mypy concordia/cmpc: success, no issues found in 8 source files\n- .venv/bin/pytest -q: 1168 passed\n\nNext: PR 4 (atomic activation + unwind).