This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Fix false positive in maybe expression #1531
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkoMin
force-pushed
the
maybe_expr_fix
branch
from
af167dd to
eb7bab4
Compare
|
Just discovered that not only |
|
Turns out we'll have to wait for new OTP release to fix it. When I run this with OTP patch I submitted, the added testcase passes. P.S: How should we this in lower OTP versions? |
MarkoMin
force-pushed
the
maybe_expr_fix
branch
from
8d0a1a1 to
827bc10
Compare
|
PR got merged in OTP so I will test this one the new release is out. This should work for OTP > 27.2. I have no idea if we can fix this for earlier versions of OTP |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here is just the test case that confirms it. Hope I'd manage to get some time to write a solution.
Fixes #1527