Skip to content

Fix socket related PVS Studio findings #10388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

Fix socket related PVS Studio findings #10388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e59830c
erts: fix tcp_send_error econnaborted for win32
themiron Nov 10, 2025
701a876
erts: fix socket sendile Offset out of bounds check
RaimoNiskanen Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion erts/emulator/drivers/common/inet_drv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13522,7 +13522,7 @@ static int tcp_send_error(tcp_descriptor* desc, int err)
* show_econnreset socket option enabled to receive {error, econnreset} on
* both send and recv operations to indicate that an RST has been received.
*/
#ifdef __WIN_32__
#ifdef __WIN32__
if (err == ECONNABORTED)
err = ECONNRESET;
#endif
Expand Down
2 changes: 1 addition & 1 deletion erts/emulator/nifs/common/prim_socket_nif.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6040,7 +6040,7 @@ nif_sendfile(ErlNifEnv* env,

if ((! (a2ok = GET_INT64(env, argv[2], &offset64))) ||
(! GET_UINT64(env, argv[3], &count64u))) {
if ((! IS_INTEGER(env, argv[3])) ||
if ((! IS_INTEGER(env, argv[2])) ||
(! IS_INTEGER(env, argv[3])))
return enif_make_badarg(env);
if (! a2ok)
Expand Down
Loading