Skip to content

Conversation

@RaimoNiskanen
Copy link
Contributor

@RaimoNiskanen RaimoNiskanen commented Nov 19, 2025

This PR adds the option for MPTCP to the inet_backend=socket compatibility module.

It also adds some fairly Linux specific socket options TCP_KEEP{CNT,IDLE,INTVL} and the slightly more generic TCP_USER_TIMEOUT, to both gen_tcp (and the compatibility module) and socket.

The TCP_KEEP_* options already existed in socket.

Update the documentation to mention this option
and some other that were overlooked.
Options TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL and TCP_USER_TIMEOUT
with Erlang names `keepcnt`, `keepidle`, `keepintvl` and `user_timeout`
for `gen_tcp` and `inet` `setopts` and `getopts`.
@RaimoNiskanen RaimoNiskanen added this to the 28.2 milestone Nov 19, 2025
@RaimoNiskanen RaimoNiskanen requested a review from bmk November 19, 2025 16:19
@RaimoNiskanen RaimoNiskanen self-assigned this Nov 19, 2025
@RaimoNiskanen RaimoNiskanen added team:PS Assigned to OTP team PS feature labels Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

CT Test Results

    4 files    196 suites   1h 54m 52s ⏱️
3 225 tests 2 828 ✅ 395 💤 2 ❌
4 122 runs  3 646 ✅ 474 💤 2 ❌

For more details on these failures, see this check.

Results for commit f558420.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

bmk
bmk previously approved these changes Nov 20, 2025
@RaimoNiskanen RaimoNiskanen changed the base branch from master to maint November 20, 2025 14:05
@RaimoNiskanen RaimoNiskanen dismissed bmk’s stale review November 20, 2025 14:05

The base branch was changed.

@RaimoNiskanen RaimoNiskanen requested a review from bmk November 20, 2025 14:06
@RaimoNiskanen RaimoNiskanen merged commit f558420 into erlang:maint Nov 20, 2025
28 of 30 checks passed
@RaimoNiskanen RaimoNiskanen deleted the raimo/mptcp-maint/OTP-19857 branch November 21, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature team:PS Assigned to OTP team PS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants