Polish rand:shuffle and write more shell test documentation
#10399
+578
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use specified algorithms when measuring.
This reverts commit 5dd78a1.
This reverts commit 3ace5c9.
This reverts commit 7a0c4af.
* mwc59 and dedicated shuffle implementations:
Revert "Try the speed of mwc59 in particular for shuffle"
Revert "Try dedicated shuffle_mwc59"
Revert "Try dedicated shuffle_exsss"
Try dedicated shuffle_exsss
Try dedicated shuffle_mwc59
Try the speed of mwc59 in particular for shuffle
Results:
* mwc59 only makes a difference for shuffle, not for bytes
* An inlined shuffle_mwc59 is about 20 % faster than exsss
* An inlined shuffle_exsss is as fast as shuffle_mwc59
Hence, it can give 20% to inline the PRNG functions in shuffle,
so it is not worth the code duplication, and the speed of mwc59
is buried in the shuffle algorithm so there is no point in
having it in the plug-in framework.
Contributor
CT Test Results 2 files 97 suites 1h 8m 1s ⏱️ Results for commit d8bb3cc. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
dgud
reviewed
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes the
rand:shuffleimplementation a wee bit by using more bits from the raw PRNG, and using more of the already existing utility macros.It also adds a few more tests and shell examples documentation for all functions.
Hidden in a side track is also tests to see if how much hard optimized shuffle functions could improve performance, but it ended up in not worth the complexity...