Accept 4-arg handshake complete function in dist util - #10478
Merged
Conversation
Contributor
CT Test Results 4 files 199 suites 1h 55m 53s ⏱️ Results for commit 7da680b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
rickard-green
added
the
testing
jhogberg
removed
the
testing
zzydxm
changed the title
zzydxm
force-pushed
the
handshake_complete
branch
from
March 23, 2026 15:55
7eea393 to
7071cb9
Compare
zzydxm
force-pushed
the
handshake_complete
branch
from
March 24, 2026 13:37
7071cb9 to
7da680b
Compare
rickard-green
added
the
testing
rickard-green
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently using erldist_filter to add extra security to all our dist connections by not allowing certain dist messages to pass through.
We have a special logic like here for us to enable the filter on dist connection setup https://github.com/WhatsApp/erldist_filter/blob/main/apps/erldist_filter/src/erldist_filter_otp_28_inet_tcp_dist.erl#L1037-L1039
If dist_util can allow a 5-arg handshake_complete function like this PR, we could avoid copying dist_util on every OTP upgrade and would be really great for us. The creation and flags of the connection also seems general enough information that the dist protocol can know.
This replaces #8473 if exposing the entire HSData is too much.
Thanks!