Skip to content

Embedded 3pp alternatives - #10886

Closed
rickard-green wants to merge 6 commits into
erlang:maint-28from
rickard-green:rickard/3pp-alt/OTP-20013
Closed

Embedded 3pp alternatives#10886
rickard-green wants to merge 6 commits into
erlang:maint-28from
rickard-green:rickard/3pp-alt/OTP-20013

Conversation

@rickard-green

@rickard-green rickard-green commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@rickard-green rickard-green self-assigned this Mar 19, 2026
@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Mar 19, 2026
@rickard-green rickard-green changed the title Embedded 3pps alternatives Embedded 3pp alternatives Mar 19, 2026
@github-actions

github-actions Bot commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CT Test Results

    3 files    142 suites   50m 26s ⏱️
1 654 tests 1 598 ✅ 56 💤 0 ❌
2 376 runs  2 301 ✅ 75 💤 0 ❌

Results for commit c99c94a.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

kikofernandez
kikofernandez reviewed Mar 19, 2026
View reviewed changes
Comment thread erts/doc/src/erlang_system_info.md Outdated
@rickard-green
rickard-green force-pushed the rickard/3pp-alt/OTP-20013 branch 2 times, most recently from 930814a to 4463339 Compare March 20, 2026 21:40
@garazdawi

garazdawi commented Mar 23, 2026

Copy link
Copy Markdown
Member

The add vendor description in SBOM.md should probable be extended to include updating this. Speaking of SBOM, should the generated SBOM reflect the options given to configure? or maybe the sbom trimming functionality in otp-compliance.es should also trim based on a specific erts configuration?

@rickard-green
rickard-green force-pushed the rickard/3pp-alt/OTP-20013 branch from 4463339 to 0e3f043 Compare March 25, 2026 14:41
@rickard-green

rickard-green commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

The add vendor description in SBOM.md should probable be extended to include updating this.

👍 Added

Speaking of SBOM, should the generated SBOM reflect the options given to configure? or maybe the sbom trimming functionality in otp-compliance.es should also trim based on a specific erts configuration?

We've discussed this. It would be nice with trimming based on what's included/excluded when building. Not something we've gotten to yet, though.

@rickard-green rickard-green added the testing currently being tested, tag is used by OTP internal CI label Mar 25, 2026
@rickard-green
rickard-green force-pushed the rickard/3pp-alt/OTP-20013 branch 5 times, most recently from fcea811 to b731351 Compare March 30, 2026 15:15
sverker
sverker previously approved these changes Mar 30, 2026
View reviewed changes
@rickard-green
rickard-green force-pushed the rickard/3pp-alt/OTP-20013 branch from b731351 to 3410f60 Compare March 31, 2026 09:27
@rickard-green
rickard-green changed the base branch from maint to maint-28 March 31, 2026 09:36
@rickard-green
rickard-green force-pushed the rickard/3pp-alt/OTP-20013 branch 2 times, most recently from 8194a7b to 3410f60 Compare March 31, 2026 12:50
sverker
sverker previously approved these changes Mar 31, 2026
View reviewed changes
@rickard-green
rickard-green changed the base branch from maint-28 to maint April 15, 2026 12:05
@rickard-green
rickard-green force-pushed the rickard/3pp-alt/OTP-20013 branch from ca02da3 to b76bf84 Compare April 15, 2026 12:06
@rickard-green
rickard-green changed the base branch from maint to maint-28 April 15, 2026 15:06
rickard-green and others added 3 commits April 20, 2026 14:34
@rickard-green @sverker
[erts] Fix 3pp alternatives configure tests
88f2411
@rickard-green @sverker
[erts] Fix alternate erl_errno_id() implementation
e9d52e5
@sverker
erts: Add alternative to ryu for float_to_list(_,[short])
c99c94a 
Backported from 29(master) to 28
from d1eafda
and 2efda9e

Alternative implementation uses std::to_chars() in C++17 STL.
String output is compatible with ryu.
Configure defaults to ryu.
@sverker
sverker force-pushed the rickard/3pp-alt/OTP-20013 branch from b76bf84 to c99c94a Compare April 20, 2026 12:43
@sverker sverker mentioned this pull request Apr 20, 2026
Merged
@sverker

sverker commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Replaced by #11045.

@sverker sverker closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kikofernandez kikofernandez kikofernandez left review comments
@sverker sverker sverker left review comments

Assignees

@rickard-green rickard-green

Labels

team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickard-green @garazdawi @sverker @kikofernandez