Skip to content

Doctests addition - #10891

Merged
bjorng merged 1 commit into
erlang:masterfrom
spoo:doctests-addition
Apr 8, 2026
Merged

Doctests addition#10891
bjorng merged 1 commit into
erlang:masterfrom
spoo:doctests-addition

Conversation

@spoo

@spoo spoo commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

This PR adds doctest examples to base64 module for most of the functions

@github-actions

github-actions Bot commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CT Test Results

    2 files    100 suites   1h 10m 4s ⏱️
2 288 tests 2 236 ✅ 52 💤 0 ❌
2 707 runs  2 651 ✅ 56 💤 0 ❌

Results for commit 8a4e699.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@CLAassistant

CLAassistant commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Mar 23, 2026
@spoo
spoo force-pushed the doctests-addition branch from 7239423 to 9be75a4 Compare March 23, 2026 14:33
@bjorng

bjorng commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Please sign the CLA and squash the commits.

@spoo
spoo force-pushed the doctests-addition branch from 9be75a4 to 746566d Compare March 24, 2026 19:59
@spoo

spoo commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for your pull request. Please sign the CLA and squash the commits.

I have squashed commits but somehow there needs to be approval for CI checks if that could be checked

@spoo spoo closed this Mar 27, 2026
@spoo
spoo force-pushed the doctests-addition branch from 57efb5b to b7dfac8 Compare March 27, 2026 11:04
@spoo spoo reopened this Mar 30, 2026
@bjorng bjorng added the testing currently being tested, tag is used by OTP internal CI label Mar 30, 2026
@bjorng

bjorng commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Added to our daily builds for testing.

@spoo
spoo force-pushed the doctests-addition branch 2 times, most recently from 5004240 to 5ee20b9 Compare March 30, 2026 12:29
@bjorng bjorng removed the testing currently being tested, tag is used by OTP internal CI label Mar 30, 2026
bjorng
bjorng requested changes Mar 30, 2026
View reviewed changes

@bjorng bjorng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, except for a missing blank line. I also have a suggestion to pass in some options to ct_doctest call.

Comment thread lib/stdlib/src/base64.erl
Comment thread lib/stdlib/test/base64_SUITE.erl Outdated
@spoo
Added base64 doctests
8a4e699 
Indentation fixes
Doctest fixes
CT Suite options update
@spoo
spoo force-pushed the doctests-addition branch from 5ee20b9 to 8a4e699 Compare April 2, 2026 08:55
@bjorng bjorng added the testing currently being tested, tag is used by OTP internal CI label Apr 2, 2026
@bjorng

bjorng commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Thanks! Added to our daily builds.

@bjorng
bjorng merged commit 8c97feb into erlang:master Apr 8, 2026
27 checks passed
@bjorng

bjorng commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorng bjorng bjorng approved these changes

Assignees

@bjorng bjorng

Labels

team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spoo @CLAassistant @bjorng @rickard-green