public_key: Fix IP address name constraint handling - #11389
Open
u3s wants to merge 1 commit into
Open
Conversation
Contributor
CT Test Results 2 files 18 suites 6m 4s ⏱️ Results for commit b9831af. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
The atom 'ipAdress' (typo since R13B03) in pubkey_cert.erl did not match the ASN.1 decoder's 'iPAddress', making IP-based name constraints non-functional. Additionally, the old implementation expected list values but the decoder produces binaries. Rewrite to work with binary data natively. Also fixes 'iPAdress' variant in is_valid_subject_alt_name/1.
u3s
force-pushed
the
kuba/public_key/ipaddress_constraint_fix/OTP-20266
branch
from
July 24, 2026 08:15
ab2be64 to
b9831af
Compare
IngelaAndin
reviewed
Aug 18, 2026
Contributor
There was a problem hiding this comment.
Suggested fix:
ip_constraint_intersection(IpMask1, IpMask2) ->
{Ip1, Mask1} = split_ip_mask(IpMask1),
{Ip2, Mask2} = split_ip_mask(IpMask2),
case {contains(Ip1, Mask1, Ip2, Mask2),
contains(Ip2, Mask2, Ip1, Mask1)} of
{true, true} ->
%% Identical subnets
{ok, IpMask1};
{true, false} ->
%% Subnet1 contains Subnet2 — Subnet2 is narrower
{ok, IpMask2};
{false, true} ->
%% Subnet2 contains Subnet1 — Subnet1 is narrower
{ok, IpMask1};
{false, false} ->
empty
end.
%% Subnet IP1/Mask1 contains subnet IP2/Mask2 iff:
%% 1. Mask1 is broader (Mask1 band Mask2 == Mask1), AND
%% 2. IP2's network falls in IP1 (IP2 band Mask1 == IP1)
contains(Ip1, Mask1, Ip2, Mask2) ->
band_list(Mask1, Mask2) =:= Mask1 andalso
band_list(Ip2, Mask1) =:= Ip1.
IngelaAndin
requested changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atom 'ipAdress' (typo since R13B03) in pubkey_cert.erl did not match the ASN.1 decoder's 'iPAddress', making IP-based name constraints non-functional. Rename to correct atom.
Also fixes 'iPAdress' variant in is_valid_subject_alt_name/1.