crypto: Fix DH private key length type mismatch - #11513
Conversation
CT Test Results 2 files 14 suites 4m 25s ⏱️ Results for commit 74edf11. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
4ae7e50 to
3a813ec
Compare
|
Could you rebase the branch from patch-base-27 tag? |
3a813ec to
37f5b5a
Compare
|
Well, there are conflicts on github unfortunately :(. In that case you can base it again on maint, and we will create more branches for older releases internally. Sorry about that :( |
Signed-off-by: ruslandoga <ruslandoga+gh@icloud.com>
37f5b5a to
74edf11
Compare
|
I think we can avoid the copy (and additional variable on stack) by having a union with ErlNifUint64 and uint64_t instead, what do you think about this approach? |
enif_get_uint64()writes through anErlNifUInt64 *, whileOSSL_PARAM_construct_uint64()builds a parameter pointing touint64_tstorage. On macOS arm64, those are equally wide but distinct C types:
ErlNifUInt64isunsigned long, whileuint64_tisunsigned long long.Fixes #11511