erts: Only translate \r\n on character devices in fd ports - #11531
Open
garazdawi wants to merge 1 commit into
Open
erts: Only translate \r\n on character devices in fd ports#11531garazdawi wants to merge 1 commit into
garazdawi wants to merge 1 commit into
Conversation
Contributor
CT Test Results 3 files 136 suites 52m 28s ⏱️ Results for commit 3a0e828. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
If the input handle is a pipe or something different we don't want to do any translation at all, but if it is a character device we translate \r\n to \n so that it mimics how terminals on Linux works a little bit better. As open_port fd is not used anymore for the normal erlang terminal this change only effects thirdparty usage which usually is from pipes that do not want any translation to happen. Closes erlang#10258
garazdawi
force-pushed
the
lukas/erts/fix-windows-crlf-translation
branch
from
August 25, 2026 18:51
03efcb5 to
3a0e828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the input handle is a pipe or something different we don't want to do any translation at all, but if it is a character device we translate \r\n to \n so that it mimics how terminals on Linux works a little bit better. As open_port fd is not used anymore for the normal erlang terminal this change only effects thirdparty usage which usually is from pipes that do not want any translation to happen.
Closes #10258