Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: Handle defaults on version change #9418

Merged

Conversation

IngelaAndin
Copy link
Contributor

This fixes a bug handling default options when later setting of options changes the versions option. Some more commits enhancing socket options handling is also planned before finishing this PR. And backporting of the bugfix to 27 track.

@IngelaAndin IngelaAndin self-assigned this Feb 11, 2025
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

CT Test Results

    2 files     66 suites   26m 56s ⏱️
  810 tests   768 ✅  42 💤 0 ❌
4 160 runs  3 356 ✅ 804 💤 0 ❌

Results for commit 4df6212.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin force-pushed the ingela/ssl/socket-inherit/OTP-19457 branch from 938a51d to fe7361a Compare February 11, 2025 15:34
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Feb 12, 2025
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/socket-inherit/OTP-19457 branch from fe7361a to 1a85bc4 Compare February 13, 2025 11:20
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/socket-inherit/OTP-19457 branch from 1a85bc4 to 4df6212 Compare February 17, 2025 07:11
@IngelaAndin IngelaAndin requested review from u3s and dgud February 18, 2025 13:17
@IngelaAndin
Copy link
Contributor Author

As this is already released for OTP-27. I will merge this and add other ideas later as other things has taken priority.

@IngelaAndin IngelaAndin merged commit d5205bb into erlang:master Feb 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants