Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "on the form" with "of the form" #9431

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

bjorng
Copy link
Contributor

@bjorng bjorng commented Feb 13, 2025

"On the form" is used when something is written on a paper or electronic form, for example on a tax form.

To express that something has the shape or structure of something else, the correct expression is "of the form" or "in the form".

Thanks to Richard O'Keefe for pointing this out. See https://erlangforums.com/t/otp-28-0-rc1-released/4482/3.

@bjorng bjorng added team:VM Assigned to OTP team VM fix testing currently being tested, tag is used by OTP internal CI labels Feb 13, 2025
@bjorng bjorng self-assigned this Feb 13, 2025
Copy link
Contributor

github-actions bot commented Feb 13, 2025

CT Test Results

    14 files     761 suites   5h 28m 17s ⏱️
 7 571 tests  7 057 ✅ 514 💤 0 ❌
14 164 runs  13 445 ✅ 719 💤 0 ❌

Results for commit b33abad.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

garazdawi
garazdawi previously approved these changes Feb 13, 2025
"On the form" is used when something is written on a paper or
electronic form, for example on a tax form.

To express that something has the shape or structure of something
else, the correct expression is "of the form" or "in the form".

Thanks to Richard O'Keefe for pointing this out. See
https://erlangforums.com/t/otp-28-0-rc1-released/4482/3.
@bjorng bjorng requested a review from garazdawi February 14, 2025 04:55
@bjorng bjorng merged commit ab098b9 into erlang:master Feb 14, 2025
37 checks passed
@bjorng bjorng deleted the bjorn/of-the-form branch February 14, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants