erts: Remove faulty assert checking for DELAYED_DEL_PROC flag #9451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Erlang/OTP 22 functionality was added to yield after process "death" in order to send large error reasons for down/exit signals. This change meant that we not can be in state FREE, but the DELAYED_DEL_PROC is first set later, so the assert checking for it is incorrecy.
CT Test Results 3 files 143 suites 48m 47s ⏱️ Results for commit 1e0dfe2. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
added
the
testing
rickard-green
approved these changes
Feb 20, 2025
garazdawi
deleted the
lukas/erts/remove-faulty-dirty-free-proc-assert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Erlang/OTP 22 functionality was added to yield after process "death" in order to send large error reasons for down/exit signals. This change meant that we not can be in state FREE, but the DELAYED_DEL_PROC is first set later, so the assert checking for it is incorrecy.