Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inets: Polish mod_esi documentation #9472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jchristgit
Copy link
Contributor

@jchristgit jchristgit commented Feb 23, 2025

This commit:

  • Moves the data type documentation for env() directly to the data type itself
  • Introduces the opaque session_id() data type
  • Adds a summary header for the callback and deliver functions
  • Removed the redundant "ESI Callback Functions" part of the "Callbacks" header
  • Groups and reword the callback docs to be more readable.

If wanted, I can add since for the new type, but I'd need a ticket number for that.

Copy link
Contributor

github-actions bot commented Feb 23, 2025

CT Test Results

  2 files   22 suites   9m 57s ⏱️
352 tests 347 ✅  5 💤 0 ❌
622 runs  571 ✅ 51 💤 0 ❌

Results for commit a13f9f9.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

This commit:

- Moves the data type documentation for `env()` directly to the data
  type itself
- Introduces the opaque `session_id()` data type
- Adds a summary header for the callback and `deliver` functions
- Removed the redundant "ESI Callback Functions" part of the "Callbacks"
  header
- Groups and reword the callback docs to be more readable.
@jchristgit jchristgit changed the title intes: Polish mod_esi documentation inets: Polish mod_esi documentation Feb 23, 2025
@rickard-green rickard-green added the team:PS Assigned to OTP team PS label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants