spelling: "hopeful" #9474
Open
spelling: "hopeful" #9474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopefull -> hopeful, except in the places which could potentially be used as external interface.
If the trailing underscore means this is an exclusively internal interface, the change can be safely merged. But these could potentially be used directly by downstream code.
This flag seems to be internal, undocumented, and unused. Any clues?
CT Test Results 3 files 141 suites 50m 1s ⏱️ Results for commit 06c252e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Thanks for your pull request. All those changes seem to be safe. I've added the branch to our daily builds. |
bjorng
removed
the
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up a small spelling glitch. Separate commits are put in order of increasing risk, as judged by an inexperienced eye.