erts: fix binary offset bug in erl_bif_re #9478
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 141 suites 50m 8s ⏱️ Results for commit 20c15e1. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
sverker
approved these changes
Feb 24, 2025
| @@ -629,6 +629,7 @@ static bool get_iolist_as_bytes(Eterm iolist, | |||
|
|
|||
| ERTS_GET_BITSTRING(iolist, *bytes_p, bit_offs, bit_sz); | |||
| if (!BIT_OFFSET(bit_offs) && !TAIL_BITS(bit_sz)) { | |||
| *bytes_p += BYTE_OFFSET(bit_offs); | |||
There was a problem hiding this comment.
Nice catch!
A testcase that tests regex as sub-binaries would be good. Maybe also test byte unaligned regex strings even if that is very unlikely to be used in practice.
Do we even have a testcase for subject strings as sub-binaries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GH-9438