Fix having -O2 in path to otp repo
#9488
Open
+27
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garazdawi
added
team:VM
CT Test Results 3 files 141 suites 49m 59s ⏱️ Results for commit 0599222. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
bjorng
reviewed
Feb 25, 2025
| @@ -209,8 +209,7 @@ LIBS += $(TYPE_LIBS) | |||
| ORIG_LIBS:= $(LIBS) | |||
|
|
|||
| comma:=, | |||
| space:= | |||
| space+= | |||
| space:=$(subst ,, ) | |||
There was a problem hiding this comment.
I find this a little bit confusing. The documentation for make suggests the following, which I think is clearer:
Suggested change
| space:=$(subst ,, ) | |
| empty:= | |
| space:=$(empty) $(empty) |
|
I don't understand why it fails in a directory named "LINFO2", which has no hyphen before "O2". However, I can confirm that it indeed fails and that this PR eliminates the build failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9487