Stop starting applications when terminating node #9494
+237
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be never actually used - the From in the start_req is used for replying to waiting processes.
This is necessary to be able to later interact with this process
…node Applications that didn't finish starting could be left in a half-broken state during node shutdown. In particular, their dependencies would be already shut down, while the application itself was running, likely with many errors. The behaviour is to replicate what happens if the application finished starting - with timeout set, we'll respect this timeout; otherwise we'll wait forever.
CT Test Results 2 files 70 suites 1h 7m 11s ⏱️ For more details on these failures, see this check. Results for commit 7f0ee75. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications that didn't finish starting could be left in a half-broken state during node shutdown. In particular, their dependencies would be already shut down, while the application itself was running, likely with many errors. The behaviour is to replicate what happens if the application finished starting - with timeout set, we'll respect this timeout; otherwise we'll wait forever.
This has some setup work in earlier commits, trying to make the change gradual. I recommend reviewing the commits separately. In particular, we first remove the
Fromfield from thestartingqueue - it seems completely unused. This is later replaced with aStarter- tracking the process responsible for starting the application, so we can properly interact with it.Fixes #8485