add max_handlers_open option for httpc profile #9712
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whaileee
added
testing
CT Test Results 37 files 943 suites 6h 39m 29s ⏱️ For more details on these failures, see this check. Results for commit f1603f9. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Whaileee
force-pushed
the
whaileee/inets/httpc/socket_closed_remotely/GH-8841/OTP-19587
branch
2 times, most recently
from
2a8a4ad to
4e3f24f
Compare
Whaileee
force-pushed
the
whaileee/inets/httpc/socket_closed_remotely/GH-8841/OTP-19587
branch
from
4e3f24f to
92f73a1
Compare
|
@github-actions disable-cache |
Whaileee
force-pushed
the
whaileee/inets/httpc/socket_closed_remotely/GH-8841/OTP-19587
branch
2 times, most recently
from
465413d to
5e33cc0
Compare
u3s
reviewed
Apr 10, 2025
| @@ -547,6 +554,7 @@ cancel_request(RequestId, Profile) | |||
| Option :: {proxy, {Proxy, NoProxy}} | |||
| | {https_proxy, {Proxy, NoProxy}} | |||
| | {max_sessions, MaxSessions} | |||
| | {max_handlers_open, MaxHandlersOpen} | |||
There was a problem hiding this comment.
new option (API change) requires OTB involvement
Whaileee
force-pushed
the
whaileee/inets/httpc/socket_closed_remotely/GH-8841/OTP-19587
branch
2 times, most recently
from
7acd444 to
2e53f7f
Compare
|
solves #8841 |
Whaileee
force-pushed
the
whaileee/inets/httpc/socket_closed_remotely/GH-8841/OTP-19587
branch
from
2e53f7f to
f1603f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.