Skip to content

Handle built-in protocol aliases #9718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RaimoNiskanen
Copy link
Contributor

@RaimoNiskanen RaimoNiskanen added this to the OTP-28.0 milestone Apr 11, 2025
@RaimoNiskanen RaimoNiskanen requested a review from bmk April 11, 2025 17:10
@RaimoNiskanen RaimoNiskanen self-assigned this Apr 11, 2025
Copy link
Contributor

github-actions bot commented Apr 11, 2025

CT Test Results

    3 files    141 suites   49m 55s ⏱️
1 619 tests 1 563 ✅ 54 💤 2 ❌
2 340 runs  2 264 ✅ 74 💤 2 ❌

For more details on these failures, see this check.

Results for commit 0602b06.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

bmk
bmk previously approved these changes Apr 14, 2025
@RaimoNiskanen
Copy link
Contributor Author

I just pushed a suggestion to not use protocol name aliases for socket option names.

That would for example only allow {ip,recvtos} as the socket:setopts|getopts name for SOL_IP,IP_RECVTOS, and no longer allow {'IP',recvtos}, {hopopt,recvtos} and {'HOPOPT',recvtos}. The latter 3 stems from the protocols enumerated by getprotoent() (/etc/protocols) that have the same protocol number as SOL_IP.

@RaimoNiskanen RaimoNiskanen requested a review from bmk April 14, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants