Add upgrade script for ryu #9733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In erlang#9670 a lot of license headers were fixed to give better information, so a lot of curations can now be removed.
We place it in a separate file in order to move out the license information and to make it easier to pick updates.
It was only used for the ryu to_chars snippet and that is not removed.
CT Test ResultsTests are running... https://github.com/erlang/otp/actions/runs/14469948607 Results for commit 5171ac9 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
| ####################################################################### | ||
|
|
||
| https://github.com/microsoft/STL/blob/master/stl/inc/xcharconv_ryu.h has been | ||
| updated. Check that no changes effect the __to_chars function and if they do |
| @@ -14,18 +14,22 @@ | |||
| "homepage": "https://github.com/ulfjack/ryu", | |||
| "licenseDeclared": "Apache-2.0", | |||
| "name": "ryu", | |||
| "versionInfo": "844864ac213bdbf1fb57e6f51c653b3d90af0937", | |||
| "versionInfo": "1264a946ba66eab320e927bfd2362e0c8580c42f", | |||
There was a problem hiding this comment.
is there any version info? Just to see if we avoid this accidental duplication of sha in versionInfo and sha.
I think not, but just checking
There was a problem hiding this comment.
There is a version 2.0, but that is the only version ever released and there don't seem to be any new ones even if there have been many fixes since.
kikofernandez
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an splits out the
to_charsfunction taken from STL into a separate file to make license handling easier and then adds an update script that checks if there are upgrades available and if there it tries to apply them.The PR also updates ryu to the latest version.
This PR depends on the changes in #9732