Skip to content

ssh: add RUB credits for draft miller advisory #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

u3s
Copy link
Contributor

@u3s u3s commented May 9, 2025

No description provided.

@u3s u3s requested a review from Copilot May 9, 2025 07:25
@u3s u3s self-assigned this May 9, 2025
@u3s u3s added the team:PS Assigned to OTP team PS label May 9, 2025
Copy link
Contributor

github-actions bot commented May 9, 2025

CT Test Results

    2 files     29 suites   19m 44s ⏱️
  470 tests   466 ✅  4 💤 0 ❌
1 675 runs  1 651 ✅ 24 💤 0 ❌

Results for commit 43171ac.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds credit acknowledgements for the draft-miller advisory on the strict KEX implementation fix.

  • Inserts a credit note in three separate SSH version sections in the documentation.
  • Updates the vulnerability disclosure details with consistent attribution.

@garazdawi
Copy link
Contributor

While updating the notes, can you change the CVE-... in the "Aux Id" to be links to the cve? Like is done in the release description: https://github.com/erlang/otp/releases/tag/OTP-27.3.4

I thought that I had fixed it to be done automatically, but apparently not..

@u3s u3s force-pushed the kuba/ssh/add_rub_miller_credits branch from ea1b519 to 43171ac Compare May 9, 2025 09:24
@u3s
Copy link
Contributor Author

u3s commented May 9, 2025

While updating the notes, can you change the CVE-... in the "Aux Id" to be links to the cve? Like is done in the release description: https://github.com/erlang/otp/releases/tag/OTP-27.3.4

I thought that I had fixed it to be done automatically, but apparently not..

pls check links now. I assumed they should be MD.

@u3s u3s merged commit 99ebd2b into erlang:maint May 12, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants