Support env variable substitution with defaults in rebar shell #2948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sys.config.src file may since OTP 21 contain env variables with
defaults using the standard shell syntax `${FOO:-some_default}`. The
only place where Rebar itself needs to worry about this is in the
`shell` command which wants to load the sys.config, and must then
perform the substitutions first. This commit implements support for
such env variable defaults. Previously, Rebar would crash if it
encountered this syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sys.config.src file may since OTP 21 contain env variables with defaults using the standard shell syntax
${FOO:-some_default}. The only place where Rebar itself needs to worry about this is in theshellcommand which wants to load the sys.config, and must then perform the substitutions first. This commit implements support for such env variable defaults. Previously, Rebar would crash if it encountered this syntax.By some simple refactoring, this also makes the
rebar3 ct --sys_configoption work onsys.config.srcfiles.