fix!: change default pool name to pgo_default#108
Open
tsloughter wants to merge 1 commit intomainfrom
Open
Conversation
Collaborator
Author
74a079f to
5b2a546
Compare
Contributor
|
I would publish a new major version and not worry about backwards compatibility. |
Collaborator
Author
|
Yea, maybe I should just do that and also include the breaking change on arrays and/or json. |
Contributor
|
I don't mind backward compatibility in this case. |
Contributor
|
I don't think backwards compatibility is possible here. There is nothing stopping people from having used the name in their code. |
Collaborator
Author
|
yea, I'm thinking I'll remove the hack and end up releasing 1.0 once I decide on how to handle array and json values (will be soon). |
5b2a546 to
4315d72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To have some backwards compatibility the use of
defaultas the pool name is not allowed. Instead any use ofdefaultwill be converted topgo_defaultwhen thepgomodule functions are in use.