Skip to content

fix!: change default pool name to pgo_default#108

Open
tsloughter wants to merge 1 commit intomainfrom
pgo-default-pool
Open

fix!: change default pool name to pgo_default#108
tsloughter wants to merge 1 commit intomainfrom
pgo-default-pool

Conversation

@tsloughter
Copy link
Collaborator

To have some backwards compatibility the use of default as the pool name is not allowed. Instead any use of default will be converted to pgo_default when the pgo module functions are in use.

@tsloughter
Copy link
Collaborator Author

Only took 3 years to fix #60 :)

@benbro @lpil any thoughts on my hack of backwards compatibility?

@lpil
Copy link
Contributor

lpil commented Dec 1, 2025

I would publish a new major version and not worry about backwards compatibility.

@tsloughter
Copy link
Collaborator Author

Yea, maybe I should just do that and also include the breaking change on arrays and/or json.

@benbro
Copy link
Contributor

benbro commented Dec 3, 2025

I don't mind backward compatibility in this case.
Thank you for the fix.

@lpil
Copy link
Contributor

lpil commented Dec 3, 2025

I don't think backwards compatibility is possible here. There is nothing stopping people from having used the name in their code.

@tsloughter
Copy link
Collaborator Author

yea, I'm thinking I'll remove the hack and end up releasing 1.0 once I decide on how to handle array and json values (will be soon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants