Fix issue on windows with Erlang/OTP 28 which causes temporary directories to get created at the wrong path.#193
Merged
ferd merged 1 commit intoJun 4, 2025
Conversation
…hen creating a temporary directory
ferd
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ec_file:tmp/0, a call to erlang:system_info(system_architecture) is used in order to determine the location to create temporary directories for each operating system. In OTP28, the result of the call is not the expected "win32" string, but the target triplet (i.e. "x86_64-pc-windows"). As a result, temporary directories are created at the wrong location, which causes unexpected behavior in downstream packages.
The fix uses os:type/0 to detect whether we are currently running on windows which has a more stable result.