Skip to content

Clarify SimdSetAmxFull API semantics in SimdLib.h - #351

Merged
ermig1979 merged 5 commits into
masterfrom
copilot/improve-function-description-simdgetthreadnumber
May 22, 2026
Merged

Clarify SimdSetAmxFull API semantics in SimdLib.h#351
ermig1979 merged 5 commits into
masterfrom
copilot/improve-function-description-simdgetthreadnumber

Conversation

Copilot AI commented May 22, 2026

Copy link
Copy Markdown
Contributor

SimdSetAmxFull was documented too loosely relative to its actual behavior. This updates the API comment in SimdLib.h to describe the real AMX-specific effect and its runtime applicability.

  • Scope of the API

    • Reworded the summary to state that the function loads the full AMX tile configuration for the current thread.
  • Behavioral semantics

    • Documented that the function applies on x86 with AMX-BF16 support.
    • Clarified that it forces loading the library’s predefined full AMX tile layout via the AMX tile configuration path.
  • Runtime applicability

    • Clarified that the function is a no-op when AMX-BF16 is unavailable or the corresponding SIMD backend is not enabled at runtime.
// Loads the library's full AMX tile configuration for the current thread
SimdSetAmxFull();

Copilot AI and others added 5 commits May 22, 2026 12:36
Agent-Logs-Url: https://github.com/ermig1979/Simd/sessions/770f5546-ba1e-447d-be39-0e66283ab0fd

Co-authored-by: ermig1979 <11633100+ermig1979@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ermig1979/Simd/sessions/24b23df2-0f6c-47d4-ad5a-ab85262562cf

Co-authored-by: ermig1979 <11633100+ermig1979@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ermig1979/Simd/sessions/ed71a6c4-5398-4630-a99f-dace61db2ad2

Co-authored-by: ermig1979 <11633100+ermig1979@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ermig1979/Simd/sessions/3b2c4f67-82c8-4651-90c1-31addbba713b

Co-authored-by: ermig1979 <11633100+ermig1979@users.noreply.github.com>
@ermig1979
ermig1979 marked this pull request as ready for review May 22, 2026 14:19
Copilot AI review requested due to automatic review settings May 22, 2026 14:19
@ermig1979
ermig1979 merged commit eb7e2bd into master May 22, 2026
Copilot AI removed the request for review from Copilot May 22, 2026 14:42
@ermig1979
ermig1979 deleted the copilot/improve-function-description-simdgetthreadnumber branch July 1, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants