Add SVE2 optimizations for SynetConvolution32fWinograd - #808
Merged
Conversation
Wire Sve2 Winograd transform kernels and Gemm32fNN into SynetConvolution32fWinograd, dispatch via Sve2::SynetConvolution32fInit, extend AutoTest coverage for Winograd shapes, and document the change in release 7.2.165. Co-authored-by: Ihar Yermalayeu <ermig1979@gmail.com>
ermig1979
marked this pull request as ready for review
August 3, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SynetConvolution32fWinogradinSimdSve2SynetConvolution32fGemm.cpp: wireSve2::WinogradKernel*SetFilter/SetInput/SetOutput,Sve2::Gemm32fNN, and Neon NHWC packed GEMM (Gemm32fNNcb*) plus Neon bias/activation (same hybrid pattern as GemmNN/GemmNT).Sve2::SynetConvolution32fWinogradfromSve2::SynetConvolution32fInitinstead of falling through to Neon Winograd.Test::SynetConvolution32fForwardAutoTestwith 3x3/2x2/1x3/1x5 Winograd shapes (NHWC block 4x4/3x3/2x2 and NCHW 3x3); document in release 7.2.165.SimdSve2SynetConvolution32fGemm.cppis already listed inprj/vs2022/Sve2.vcxproj/.filtersfrom prior GemmNN/GemmNT work.Test plan
./Test "-r=.." -fi=SynetConvolution32f -tt=1 -ts=1-march=armv9-a+sve2