Skip to content

fixed lua regression and application launcher issues and made a new keyboard layout widget - #207

Open
frostedpenguin wants to merge 77 commits into
eromatiya:masterfrom
frostedpenguin:master
Open

fixed lua regression and application launcher issues and made a new keyboard layout widget#207
frostedpenguin wants to merge 77 commits into
eromatiya:masterfrom
frostedpenguin:master

Conversation

@frostedpenguin

Copy link
Copy Markdown

the repo had issues rendering the panels with lua 5.4. This was due to changes to the require function which are explained in this issue 3563. I fixed the underlined problems and it seems to work fine, except the today panel which needs further investigation. I also fixed the problems with the appearance of the application launcher and made a brand new widget that indicates the current keyboard layout used based on xkb signals

image
image
image

@Myp3a

Myp3a commented Jul 23, 2022

Copy link
Copy Markdown

I've got the problem with the panels. There is no need for the indexes - they turn panels into a nil.
If you define the widgets before adding them to the return function - they work fine for some reason.

Here is the patch with:

  • Panel fixes - they are showing correct data now
  • Audio widget transition to PulseAudio - now, when the Arch has moved to the Pipewire, ALSA controls aren't reliable, they are usually set to 100%. This implementation changes the volume of default Pipewire sink, as it should in modern systems.

patch.txt

@frostedpenguin

Copy link
Copy Markdown
Author

@Myp3a you were right even though indexing the require() would not produce errors the widget would not render properly. Therefore I changed my commit and now the right panel is working fine too!

@cursome

cursome commented Sep 18, 2022

Copy link
Copy Markdown

Hey @frostedpenguin ,
Surreal Isn't working anymore.
And please open a issue section in your fork, if possible add a contact way in your profile. I couldn't find any way to contact you so need to post my comment here. Please fix surreal in your fork.

Also the search button's rofi in gnawsome not working .. Expecting it as you showed up in your screenshot.

Screenshot_2022-09-19_00-42-46

@frostedpenguin

Copy link
Copy Markdown
Author

Hi @cursome I forgot to pass the global fixes from my config to the fork now I did and it works as expected. Thanks for the suggestions I have just applied them now if you have any more remarks you can create an issue or contact me!

@ildar

ildar commented Mar 24, 2023

Copy link
Copy Markdown

I love your changes. especially uniting configurations. This allows avoiding the error-prone copying.

@frostedpenguin

Copy link
Copy Markdown
Author

@ildar cheers man hope one day it gets merged 🤣. In this point I feel there isn't any use on further building it if I don't have a solid stream of feedback and issues!

@tony-nht

tony-nht commented Sep 1, 2023

Copy link
Copy Markdown

@frostedpenguin , I just want to drop by and say "Thank you so much"

After weekends of unending digging and configuring stuffs to fix broken things when following the README.MD, your fork is a complete savior for me 😄

@frostedpenguin

Copy link
Copy Markdown
Author

@ThinhNguyenHoang1 Glad I could help 😋

@mohamadali-halwani

Copy link
Copy Markdown

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants