Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core problem was that TypeConverter, while converting request path parameters (or any other request parameters outside the body), was trying to figure out the parameter's probable type
using
getSupposedType()which was fragile.This "preemptive" speculation was necessary to understand if a literal value in the request like
2should be parsed into a json string or a json number, before being passed to validation.In other words the TypeConverter was attempting to convert these literals to their expected types before validating them by their json schemas.
This "speculation" was broken if the parameter's json schema didn't have a
"type"keyword. That is actually the case when anenum(orconstis used).This PR fixes the problem by taking a very different approach on how the root problem "should we parse a path param like "2" as a string or a number" in a completely different way: now json-sKema has a lenient validation mode, which accepts number-formatted strings as numbers. Using the lenient mode while validating any request parameters outside the body makes the above
"speculation" with getSupposedType unnecessary.
Moreover, this was also a good opportunity to rework the
validator.util.convertpackage to map the request parameter strings into JsonValue instances rather than jackson JsonNodes.The mapping itself also became simpler.