UNITARY HACK--Fix dtype exceptions and add test for dtype conversion#13
UNITARY HACK--Fix dtype exceptions and add test for dtype conversion#13AdwaithaV wants to merge 2 commits intoerror-corp:mainfrom
Conversation
gderossi
left a comment
There was a problem hiding this comment.
Hi @AdwaithaV, thanks for these improvements! I think one final pass is needed and then this will be good to go- I've provided comments below. As far as git/PR stuff is concerned, if you make your changes on the same branch and then push them, this PR will get updated automatically. Also, did you run your tests locally before submitting this PR? I encountered a few errors when I checked out this branch and tried to run the data type tests- making sure tests pass before pushing commits makes debugging easier and speeds up the PR process, so I would definitely encourage it if you're not already.
|
Hi @gderossi, The test case is running fine ... |
gderossi
left a comment
There was a problem hiding this comment.
Hi @AdwaithaV, thanks for responding to my last review. I think something may have gone wrong, because there are still overwriting issues in spacecurve.py, and all of your tests from the previous commit have been erased. In your screenshot, it shows that 0 tests were run in 0.000 seconds- this doesn't mean the tests passed but that no tests were run at all. I've given some comments that will hopefully help you resolve these issues really quickly!
|
|
||
| # Ensure correct types for frenet_dict calculations. | ||
| if curve is not None: | ||
| if isinstance(curve, str): |
There was a problem hiding this comment.
This whole deleted block from line 93 to line 121 should not have been deleted. When you look at the diff between the main branch and your code, you should see only the two insertions in lines 9 and 10, and then the insertions for the type conversion.
| @@ -0,0 +1,62 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
I think something went wrong with this whole file, because now all of the tests you had previously have been deleted. I would recommend reverting to the version of this file from the previous commit and then turning that into a unit test to align with the other test files.

This PR continues the work from #12 to resolve issue #4, incorporating all of the maintainer's feedback. I sincerely apologize for accidentally closing the previous PR - as a GitHub beginner, I'm still learning the workflow and appreciate your patience.
Changes Made:
Implemented all requested changes from #12's review:
-Resolved all the minor errors and typos in the code
-Added proper datatype handling
-Included new test cases to verify the fixes
Testing:
Added comprehensive tests in test_fix_data_type.py
Next Steps:
-Will promptly address any additional feedback
-Happy to make any necessary adjustments
-Appreciate any guidance on best practices
Thank you for your time and understanding as I learn the contribution process. This has been a valuable learning experience in:
-Proper GitHub workflow
-Code review implementation
-JAX
Resolves #4
Follow-up to #12
Thankyou!