Feature/sympy simplify#24
Conversation
|
There seems to be an index problem in the "sum ... until 20" test, which has been corrected to |
|
Oh interesting. I'll check into that. |
|
@erwanp I've fixed the index problem you pointed out, I think I must've forked from an old version. Let me know if anything else needs fixed. |
|
I think you can fix the last conflict from the online interface. Else I'll do it! |
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 81.09% 79.41% -1.68%
==========================================
Files 13 13
Lines 603 617 +14
==========================================
+ Hits 489 490 +1
- Misses 114 127 +13
Continue to review full report at Codecov.
|
|
Test crash with : I think we should maintain compatibility with 2.7 for some time, but this feature is nice. Can you move the import within the function maybe ? |
|
For sure. Should I break this off from your |
|
I'd say keep it within simplify_fractions. #22 OP @turner-eng expected to find this behavior. Less parameters also make the code easier to understand. We could escape the simplify_fraction test with |
Working simplification for Issue #22. Uses
sympyto do the simplification.Requested use case:
py2tex('theta = w_k * a ** 4 / t ** 4 / E', simplify_fractions=True)now outputs$$\theta=\frac{a^{4} w_{k}}{E t^{4}}$$.