feat(email): wire MessageIdUtil into TicketEmail + signed Reply-To#50
Merged
Conversation
mpge
force-pushed
the
feat/email-service-wireup
branch
from
April 27, 2026 01:48
c47f42f to
40e6999
Compare
Refactors TicketEmail to delegate Message-ID generation to Escalated.Services.Email.MessageIdUtil (added in #33) so the format matches the canonical NestJS reference: before: <escalated-{reference}@{domain}> <escalated-{reference}-{reply.id}@{domain}> after: <ticket-{id}@{domain}> <ticket-{id}-reply-{reply_id}@{domain}> Adds signed_reply_to/1 that returns reply+{id}.{hmac8}@{domain} or nil when email_inbound_secret is empty. Both threading_headers_for_ticket and threading_headers_for_reply include the Reply-To header when the secret is configured. New config key: config :escalated, email_inbound_secret: "..." Updates existing message_id_for_* tests for the new format. Adds 5 new tests covering signed_reply_to/1 with + without secret, and the Reply-To wire-up through both threading header helpers.
mpge
force-pushed
the
feat/email-service-wireup
branch
from
April 27, 2026 01:55
40e6999 to
c7d5ec6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers auto-closed #34 (base feat/email-message-id squash-merged via #33). Rebased onto current master.