feat(skills): admin skills management parity (#60)#62
Merged
Conversation
Brings escalated-spring to feature parity with the canonical Skills-management contract: - Flyway V4 creates the agent_skills junction (id, user_id, skill_id, proficiency 1..5 default 3, timestamps, unique(user_id, skill_id)) - V5 creates skill_routing_tags (skill_id, tag_id, unique) - V6 creates skill_routing_departments (skill_id, department_id, unique) - New AgentSkill, SkillRoutingTag, SkillRoutingDepartment entities + repositories - Skill gains slug + routing_tags/routing_departments/agent_skills @onetomany - AgentProfile drops its old @manytomany skills; AgentService.setSkills now manages AgentSkill rows with default proficiency 3 - New SkillService + SkillRoutingService implementing the explicit-mapping contract (required skills = tag overlap OR dept membership; eligible agents must cover every required skill; ordered by sum of proficiency desc) - New SkillController at /escalated/api/admin/skills with the 6 routes - Test coverage for the controller, service, routing service, and AgentService changes Authored by Cursor against the brief in PROMPT-CURSOR-SKILLS.md (local-only). Java toolchain wasn't available in the dispatch environment; CI is the verification gate. Refs escalated-developer-context domain-model/skills-management.md and the 2026-05-13 routing ADR.
mpge
force-pushed
the
feat/admin-skills-management
branch
from
May 17, 2026 16:47
4a99779 to
a3fca48
Compare
The dev.escalated:escalated-locale:0.1.0 Maven dependency added in #51 (feat(i18n)) is unresolvable: escalated-locale's publish.yml has a Maven job that exits 0 when MAVEN_USERNAME / MAVEN_PASSWORD / MAVEN_GPG_PASSPHRASE secrets are missing, and those secrets are not currently configured. CI on main has failed for this reason since 2026-05-10. Vendoring the 14 messages_*.properties files into src/main/resources/META-INF/escalated/locale/ unblocks CI without changing the classpath layout that MessageSourceConfig already reads from. When the Maven Central publish pipeline is wired up, the inline files can be deleted and the dependency restored in build.gradle.kts.
Member
Author
|
Skills parity is complete and all required checks are green (checkstyle + tests). Notes for the merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #60
Made with Cursor