fix(run): reject empty tasks - #384
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
solomonneas
force-pushed
the
agent/issue-378
branch
from
July 20, 2026 02:17
f1568a5 to
469b7ca
Compare
solomonneas
force-pushed
the
agent/issue-378
branch
from
July 20, 2026 02:33
469b7ca to
fcfc311
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378.
What changed
brigade runtask arguments during argparse validation.aboyeur.run().Root cause
Argparse required the positional task to be present but accepted an explicitly supplied blank string.
dispatch()then performed setup and created artifacts before any task-content check.Verification
brigade work verify run --target . --command "./scripts/verify" --capture brigade-work20260720-014725-work-verify-b083f5Risk
The CLI now exits with argparse status 2 for input that never represented a runnable task. Valid task parsing and detached command forwarding are unchanged.